Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(talk_app): Fix reactions overflow #2674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

Fixes #2671

image

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.90%. Comparing base (388dac9) to head (117d7a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
- Coverage   28.90%   28.90%   -0.01%     
==========================================
  Files         372      372              
  Lines      136624   136622       -2     
==========================================
- Hits        39491    39489       -2     
  Misses      97133    97133              
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 388dac9
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 388dac9
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 388dac9
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 388dac9
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 388dac9
neon_dashboard 96.05% <ø> (ø) Carriedforward from 388dac9
neon_framework 61.44% <ø> (ø)
neon_http_client 93.61% <ø> (ø) Carriedforward from 388dac9
neon_notifications 100.00% <ø> (ø) Carriedforward from 388dac9
neon_storage 94.66% <ø> (ø) Carriedforward from 388dac9
neon_talk 99.45% <ø> (ø) Carriedforward from 388dac9
nextcloud 24.33% <ø> (ø) Carriedforward from 388dac9
notifications_app 97.43% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 388dac9
talk_app 99.00% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...k/packages/talk_app/lib/src/widgets/reactions.dart 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talk reactions overflow if there are too many different reations
1 participant