feat(notifications_push_repository): Verify push notification signature #2659
+136
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/notifications_push_repository/verify-notification-signature
branch
from
181c2f9
to
a10e9de
Compare
Leptopoda
reviewed
Nov 19, 2024
| base64.decode(signature), | ||
| ); | ||
| if (!valid) { | ||
| throw Exception('Failed to verify push notification signature!'); |
There was a problem hiding this comment.
Maybe we should add a custom PushNotificationException instead of throwing a generic one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213
We don't need to catch the exception, as we can not do anything about it and it should never happen, unless the Nextcloud server or the UnifiedPush provider are compromised.