Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud_test_presets): Add and verify app release checksums #2537

Merged

Conversation

provokateurin
Copy link
Member

Ensures we always download a valid file and that the release can not be replaced without noticing it.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.66%. Comparing base (d34f98e) to head (76fff24).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   28.66%   28.66%           
=======================================
  Files         366      366           
  Lines      136296   136296           
=======================================
  Hits        39076    39076           
  Misses      97220    97220           
Flag Coverage Δ *Carryforward flag
account_repository 98.76% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 8ee337b
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 8ee337b
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 8ee337b
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 8ee337b
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 8ee337b
neon_dashboard 96.05% <ø> (ø) Carriedforward from 8ee337b
neon_framework 59.20% <ø> (ø)
neon_http_client 97.50% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 8ee337b
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from 8ee337b
nextcloud 24.26% <ø> (ø)
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.59% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 8ee337b
talk_app 98.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to store the file?
I'm not a fan of many files cluttering my tmp folder if not needed.

  1. The sha checksum should directly convert the byte stream
  2. If we need the caching to avoid multiple downloads just store the hash in a map.

@provokateurin
Copy link
Member Author

If we need the caching to avoid multiple downloads just store the hash in a map.

Good idea, somehow I didn't think about that solution 🤦‍♀️

@provokateurin provokateurin force-pushed the feat/nextcloud_test_presets/app-release-checksums branch from 45708e9 to 9f719da Compare October 1, 2024 21:11
@provokateurin provokateurin force-pushed the feat/nextcloud_test_presets/app-release-checksums branch from 9f719da to de310fa Compare October 2, 2024 06:07
@provokateurin provokateurin force-pushed the feat/nextcloud_test_presets/app-release-checksums branch from de310fa to c09f5d8 Compare October 7, 2024 02:50
@provokateurin provokateurin force-pushed the feat/nextcloud_test_presets/app-release-checksums branch from c09f5d8 to 76fff24 Compare October 9, 2024 09:13
@provokateurin provokateurin merged commit 9692c52 into main Oct 9, 2024
10 checks passed
@provokateurin provokateurin deleted the feat/nextcloud_test_presets/app-release-checksums branch October 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants