-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextcloud_test_presets): Add and verify app release checksums #2537
feat(nextcloud_test_presets): Add and verify app release checksums #2537
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
=======================================
Coverage 28.66% 28.66%
=======================================
Files 366 366
Lines 136296 136296
=======================================
Hits 39076 39076
Misses 97220 97220
*This pull request uses carry forward flags. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to store the file?
I'm not a fan of many files cluttering my tmp folder if not needed.
- The sha checksum should directly convert the byte stream
- If we need the caching to avoid multiple downloads just store the hash in a map.
Good idea, somehow I didn't think about that solution 🤦♀️ |
45708e9
to
9f719da
Compare
packages/nextcloud/packages/nextcloud_test_presets/lib/src/generate_presets.dart
Outdated
Show resolved
Hide resolved
9f719da
to
de310fa
Compare
de310fa
to
c09f5d8
Compare
…ases Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
c09f5d8
to
76fff24
Compare
Ensures we always download a valid file and that the release can not be replaced without noticing it.