Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to force end users to actively select a suitable local directory #7497

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

option to force end users to actively select a suitable local directory #7497

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9895271
do not provide a default local directory
rwalke Nov 13, 2024
7339ba9
Fix(l10n): Update translations from Transifex
nextcloud-bot Nov 14, 2024
b13f0bf
Merge branch 'master' into feature/proposeLocalDir
rwalke Nov 14, 2024
cd543c6
Merge branch 'nextcloud:master' into feature/proposeLocalDir
rwalke Nov 21, 2024
2897e92
Merge branch 'nextcloud:master' into feature/proposeLocalDir
rwalke Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/gui/owncloudsetupwizard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ void OwncloudSetupWizard::startWizard()
localFolder = QDir::homePath() + QLatin1Char('/') + localFolder;
}

localFolder = "Please select folder";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see in line 119, localFolder is meant to be a path to a local folder.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to add a few more lines of code so that the general user gets the default folder as usual. Only in special cases do I want to force the user to manually select a folder without a default (or an institution-specific default).

_ocWizard->setProperty("localFolder", localFolder);
{
ConfigFile cfg;
Expand Down