Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logs to the files explorer integration DLL #6557

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgallien
Copy link
Collaborator

No description provided.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6557-d017e1dab4796e613a7f85fa14ca42acd5cda52c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)


#include <string>
#include <vector>
#include <fstream>
#include <WinSock2.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
WinSock2.h file not found

@@ -16,9 +16,13 @@
#define NCCONTEXTMENU_H

#pragma once
#include "NCClientInterface.h"

#include <shlobj.h> // For IShellExtInit and IContextMenu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
shlobj.h file not found

@@ -17,13 +17,14 @@

#pragma once

#include <shlobj.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
shlobj.h file not found

@@ -17,13 +17,14 @@

#pragma once

#include <shlobj.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
shlobj.h file not found


#include <string>
#include <vector>
#include <fstream>
#include <WinSock2.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
WinSock2.h file not found

@@ -64,7 +65,7 @@
HANDLE _newQueries;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
unknown type name HANDLE

@@ -16,9 +16,13 @@
#define NCCONTEXTMENU_H

#pragma once
#include "NCClientInterface.h"

#include <shlobj.h> // For IShellExtInit and IContextMenu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
shlobj.h file not found


#include <string>
#include <vector>
#include <fstream>
#include <WinSock2.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
WinSock2.h file not found

Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants