step3 자동차 경주 구현 #1528
Open
step3 자동차 경주 구현 #1528
+147
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaaac
requested changes
Nov 6, 2023
| import racingcar.view.ResultView | ||
|
|
||
| class Racing<T: Runnable>(private val racingCarFactory: () -> T) { | ||
| fun race() { |
There was a problem hiding this comment.
자동차 경주 단계부터는 실행할 수 있는 main 함수를 만들어주셔야합니다. 실제로 경주가 잘 되는지 확인도 해야하구요.
Comment on lines
+14
to
+16
| override fun getDistance(): Int { | ||
| val randomNumber = RandomGenerator.getRandomIntNumber(RANDOM_THRESHOLD) | ||
| return if (randomNumber >= 4) 1 else 0 |
There was a problem hiding this comment.
수업 자료나 수업 다시보기 영상을 참고해서 테스트 가능한 구조로 구현해보시면 좋을 것 같아요. 랜덤을 만들어내는 부분을 도메인 바깥으로 분리하는 게 핵심이 되겠네요.
부족한 테스트도 자연스럽게 해결될 것 같습니다.
Comment on lines
+7
to
+10
| // SystemOutExtension을 사용하여 콘솔 출력을 캡처 | ||
| context("racing 통합 테스트") { | ||
| val racing = Racing { RacingCar() } | ||
| racing.doRacing(3, 5) |
There was a problem hiding this comment.
요구사항을 꼼꼼하게 체크해보시면
View에 대한 테스트는 작성하지 않으셔도 됩니다. 도메인 객체의 테스트에 집중해서 구현해보시면 좋을 것 같아요.
| @@ -0,0 +1,9 @@ | |||
| package racingcar.utils | |||
|
|
|||
| import java.util.* | |||
There was a problem hiding this comment.
코틀린에도 Random 패키지가 존재합니다. 코틀린 과정이니만큼 코틀린 패키지를 사용해보셔도 좋을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 진도가 늦네요~ 빠르게 잡겠습니다!
마지막 통합테스트가 조금 부실한데요 ㅠㅠ 어떻게 테스트 방향성을 잡을지 조언 부탁드립니다!