1단계 - OneToMany (FetchType.EAGER) #128
Open
+435
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongmin4943
requested changes
Nov 27, 2024
Comment on lines
+3
to
+4
| import example.entity.Order; | ||
| import example.entity.OrderItem; |
There was a problem hiding this comment.
이 두가지 클래스를 찾지 못해 컴파일 에러가 나네요 😭
Comment on lines
13
to
+14
| public class EntityUtils { | ||
| public static ColumnInfo getIdColumn(Class<?> clazz) { |
There was a problem hiding this comment.
EntityUtils 정적 메서드들을 가진 클래스인데 정적클래스가 아닌, 특정 객체에게 책임을 주는것은 어떻게 생각하시나요?
Comment on lines
+7
to
+10
| public class ColumnInfo { | ||
| private TableInfo tableInfo; | ||
| private Class<?> columnType; | ||
| private String columnName; |
There was a problem hiding this comment.
ColumnInfo 가 TableInfo 를 가지고 있네요. 구현 외적으로 단순히 이름만 보자면, 개인적으로 TableInfo 가 ColumnInfo 들을 가지고 있는게 더 자연스럽다 생각하는데 어떻게 생각하시나요?
Comment on lines
+22
to
+24
| public Class<?> getColumnType() { | ||
| return columnType; | ||
| } |
There was a problem hiding this comment.
현재 쓰이고 있지 않네요. 당장 필요가 없다면 과감히 제거하고, 필요할때 만들어보시는건 어떨까요?
Comment on lines
+6
to
+7
| private ColumnInfo onConditionColumn1; | ||
| private ColumnInfo onConditionColumn2; |
There was a problem hiding this comment.
단순히 1, 2 라는 변수 이름을 보고 바로 명확하게 알기 어려울 것 같아요 😢
| public String toString() { | ||
| StringBuilder stringBuilder = new StringBuilder(); | ||
| stringBuilder | ||
| .append("select * from ") |
There was a problem hiding this comment.
select * 이 아닌, 필요한 필드명들을 나열해서 쿼리가 나오도록 만들어주시면 감사하겠습니다 🙇
| logger.debug("query : {}", selectQuery); | ||
| String query = selectQuery.toString(); | ||
| logger.debug(query); | ||
| assertThat(query).isEqualTo("select * from orders where id = 1 inner join order_items on orders.order_id = order_items.id;"); |
There was a problem hiding this comment.
혹시 해당 쿼리가 db 에서 실행이 가능한 정상적인 쿼리가 맞을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구조를 많이 바꾸다보니 작업량이 많아질 것 같아서 일단 PR 올려봅니다..!
계속 진행해나가겠습니다.