Step5 #5836
Open
Step5 #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seondongpyo
requested changes
Nov 7, 2024
| throw new IllegalArgumentException("Car name cannot be null or empty."); | ||
| throw new IllegalArgumentException("cannot be null or empty."); | ||
| } | ||
| if (value.length() > 5) { |
There was a problem hiding this comment.
5와 같은 숫자 리터럴은 상수로 선언하여 의미를 부여해보면 어떨까요?
Comment on lines
+17
to
+18
| @Test | ||
| void carNameCannotBeNull() { |
There was a problem hiding this comment.
@NullAndEmptySource를 활용하여 코드 중복을 줄여보면 어떨까요?
| @@ -20,7 +20,9 @@ void carDoesNotMove() { | |||
| Car car = new Car("Car") { | |||
There was a problem hiding this comment.
Car에 전략 패턴을 적용하여 자동차의 움직임을 유연하게 만들어보면 어떨까요?
https://park-algorithm.tistory.com/entry/%EC%A0%84%EB%9E%B5-%ED%8C%A8%ED%84%B4-%EC%82%AC%EC%9A%A9-%ED%9B%84%EA%B8%B0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
피드백 감사합니다.
추가로 리뷰 요청드립니다.
감사합니다 :)