step 5 : 5단계 - 자동차 경주(리팩토링) #5804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csh0034
requested changes
Oct 9, 2024
| @@ -1,4 +1,7 @@ | |||
| package racinggame.racingcar; | |||
| package racinggame.domain.race; | |||
There was a problem hiding this comment.
Race 의 경우 RacingCars 만 포함하고 있습니다.
Race 의 로직을 RacingCars 로 옮긴다면 Race 는 제거 가능하지 않을까요?
| @@ -0,0 +1,23 @@ | |||
| package racinggame.domain.racingcar; | |||
|
|
|||
| public class CarName { | |||
| @@ -42,8 +41,10 @@ private void printMessage(final String message) { | |||
| private List<String> readValidNames() { | |||
There was a problem hiding this comment.
도메인은 ui 에 접근하지 않는걸 권장하지만 ui 에서 도메인 접근은 문제 없다고 생각해요.
List<CarName> 을 그대로 리턴하도록 해보는건 어떨까요?
| @@ -11,11 +13,9 @@ private RacingCars(List<RacingCar> cars) { | |||
| } | |||
|
|
|||
| public static RacingCars create(MoveStrategy moveStrategy, List<String> nameList) { | |||
There was a problem hiding this comment.
변경이 가능하기 때문에 변수명엔 가능하면 자료형을 포함하지 않도록 해보면 좋을것 같아요.
list 는 목록이지만 프로그래밍에선 컬렉션의 하위 자료형이기 때문에
현재 인스턴스 변수명인 cars 와 같이 주로 s 를 붙혀서 복수로 표현하기도 합니다.
javajigi
requested changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경내용