Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] GUDB name consistency #1016

Merged

Conversation

danibene
Copy link
Collaborator

Description

This PR aims to improve consistency in the naming of the GUDB database for R-Peak annotations and raw ECG data. I think a difference in naming could be problematic when selecting subsets of data for benchmarking:

# Extract the right slice of data
ecg_slice = ecgs[(ecgs["Participant"] == participant) & (ecgs["Database"] == database)]
rpeaks_slice = rpeaks[(rpeaks["Participant"] == participant) & (rpeaks["Database"] == database)]

Proposed Changes

I changed download_gudb.py so that the database name for R-peaks uses an underscore instead of parentheses:

anno["Database"] = "GUDB (" + experiment + ")"

Such that it matches the corresponding name for raw ECG data:

data["Database"] = "GUDB_" + experiment

Checklist

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.

@DominiqueMakowski DominiqueMakowski merged commit 8195d2f into neuropsychology:dev Jul 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants