Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve consistency in the naming of the GUDB database for R-Peak annotations and raw ECG data. I think a difference in naming could be problematic when selecting subsets of data for benchmarking:
NeuroKit/neurokit2/benchmark/benchmark_ecg.py
Lines 83 to 85 in d42a230
Proposed Changes
I changed
download_gudb.py
so that the database name for R-peaks uses an underscore instead of parentheses:NeuroKit/data/gudb/download_gudb.py
Line 44 in d42a230
Such that it matches the corresponding name for raw ECG data:
NeuroKit/data/gudb/download_gudb.py
Line 38 in d42a230
Checklist