Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide resolution to git-annex installation via DEBIAN_FRONTEND: noninteractive env var #2

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aaronkanzer
Copy link
Collaborator

@aaronkanzer aaronkanzer commented Feb 14, 2024

@hvgazula -- Take a peek here and let me know if this resolves your concern. Seems datalad and git-annex are both there.

I think the issue here was actually that the git-annex installation required manual input to proceed; however, in the GitHub Runner everything is programatic, so an EOF error occurs. Thus, running in non-interactive mode, and instructing the runner to say "yes" to everything via -y, all becomes well 😄

I put this into Draft mode since we can clean up more here if this is sufficient. Let me know -- thanks

@hvgazula
Copy link
Collaborator

I know this option. But my goal is to propagate these installs or flags into the datalad-install action and not in a separate step. That is much cleaner. For context see this

@hvgazula
Copy link
Collaborator

@hvgazula -- Take a peek here and let me know if this resolves your concern. Seems datalad and git-annex are both there.

I think the issue here was actually that the git-annex installation required manual input to proceed; however, in the GitHub Runner everything is programatic, so an EOF error occurs. Thus, running in non-interactive mode, and instructing the runner to say "yes" to everything via -y, all becomes well 😄

I put this into Draft mode since we can clean up more here if this is sufficient. Let me know -- thanks

Just reading this with a clear head- Yes, I agree that the step fails because it needs a -y. The same action that failed on the self-hosted EC2 runs perfectly fine on GitHub runner (that is, without the need for any manual intervention). How do you explain that?

@aaronkanzer
Copy link
Collaborator Author

@hvgazula -- Take a peek here and let me know if this resolves your concern. Seems datalad and git-annex are both there.
I think the issue here was actually that the git-annex installation required manual input to proceed; however, in the GitHub Runner everything is programatic, so an EOF error occurs. Thus, running in non-interactive mode, and instructing the runner to say "yes" to everything via -y, all becomes well 😄
I put this into Draft mode since we can clean up more here if this is sufficient. Let me know -- thanks

Just reading this with a clear head- Yes, I agree that the step fails because it needs a -y. The same action that failed on the self-hosted EC2 runs perfectly fine on GitHub runner (that is, without the need for any manual intervention). How do you explain that?

The Ubuntu base image for the GitHub Actions Runner has a similar setup here, where apt-get is defaulted to say "yes" to any input -- https://github.com/actions/runner-images/blob/1812c0ce71a56a7767342cacc5176e00abec9678/images/ubuntu/scripts/build/configure-apt.sh#L19

@hvgazula
Copy link
Collaborator

Ah, I see. Makes sense.

@hvgazula
Copy link
Collaborator

quick note: the goal is to propagate the changes to install.sh in {neuronets|datalad}/datalad-action so the action is usable in any generic runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants