-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move] Common Evaluation Modules to Sparsezoo
`
#1520
Open
rahul-tuli
wants to merge
6
commits into
main
Choose a base branch
from
move-evaluator-to-sparsezoo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than overriding `load_from_registry`
rahul-tuli
requested review from
Satrat,
bfineran,
dsikka,
horheynm and
dbogunowicz
January 9, 2024 15:24
Satrat
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, see my comment on the DeepSparseEvaluationRegistry, was wondering if any of that can be moved to the SparseZoo base class
dbogunowicz
approved these changes
Jan 15, 2024
base tests failing - LGTM otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluator Move
This PR moves a few modules from
deepsparse.evaluation
tosparsezoo.evaluation
Motivation and Context
The moved modules provide a common interface for evaluating models.
This interface can be leveraged and used by both
SparseML
and
DeepSparse
to evaluate models.Since
SparseZoo
is a common dependency for both repositories, itmakes sense to move these modules to
SparseZoo
.How Has This Been Tested?
The tests for moved modules in
deepsparse.evaluation
are moved tosparsezoo.evaluation
and other deepsparse specificdeepsparse.evaluation
tests were updated to use the moved modules.Both
deepsparse
andsparsezoo
tests were run to ensure that the move did not break anything.Also ran the following eval command:
Note: This diff relies on sparsezoo diff neuralmagic/sparsezoo#411
The failing tests should pass after sparsezoo side changes are merged!