Add 24 compressor #167
Open
Add 24 compressor #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
changed the base branch from
main
to
update-folder-structure-compressors
rahul-tuli
force-pushed
the
add-24-compressor
branch
from
2015e71
to
dea129e
Compare
Closed
horheynm
previously approved these changes
Sep 26, 2024
rahul-tuli
force-pushed
the
update-folder-structure-compressors
branch
2 times, most recently
from
2f69d16
to
fc4b23c
Compare
rahul-tuli
force-pushed
the
add-24-compressor
branch
from
dea129e
to
68ca6c3
Compare
rahul-tuli
force-pushed
the
update-folder-structure-compressors
branch
from
fc4b23c
to
dd16499
Compare
Move tests Remove unused import
rahul-tuli
force-pushed
the
update-folder-structure-compressors
branch
from
dd16499
to
7155e61
Compare
rahul-tuli
force-pushed
the
add-24-compressor
branch
from
68ca6c3
to
6636872
Compare
markurtz
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Overall code looks simple. I'd like to reformulate the scope, though. Specifically, I'm not following why we are restricting to just 2:4 right now when we could easily expand this to handle all sparsity cases and detect whether it is 2:4 format, some type of structured pruning, and if not any then set as unstructured. cc @dsikka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Sparse24Compressor, for 2:4 sparse models
The code is based off #129
Depends on:
This implements Part 3 of the Design doc: https://www.notion.so/Design-Document-24-Compressor-25ac643aee604c298f2bb12a6c220861?pvs=4
Class Hierarchy:
BaseCompressor (Abstract Class) | +-- BaseSparsityCompressor (Abstract Class) | +-- Sparse24CompressorFile Structure:
compressors/ └── sparse_compressors/ ├── __init__.py ├── base.py <-- Contains BaseSparsityCompressor ├── dense.py ├── sparse_bitmask.py └── sparse24.py <-- New file for Sparse24Compressor