-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concise tracing #1513
Add concise tracing #1513
Conversation
…n for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]>
2418f2a
to
4f6f9c9
Compare
Signed-off-by: Artem Glazychev <[email protected]>
4f6f9c9
to
074691b
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
=======================================
Coverage ? 66.90%
=======================================
Files ? 257
Lines ? 12253
Branches ? 0
=======================================
Hits ? 8198
Misses ? 3540
Partials ? 515 ☔ View full report in Codecov by Sentry. |
af79bbe
to
be8a1a9
Compare
Signed-off-by: Artem Glazychev <[email protected]>
36b7c01
to
ba512e4
Compare
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: Artem Glazychev <[email protected]>
73fd0ab
to
edf767d
Compare
switch logrus.GetLevel() { | ||
case logrus.TraceLevel: | ||
return t.verbose.Request(ctx, request, opts...) | ||
case logrus.InfoLevel, logrus.DebugLevel: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. What about other levels? E.g. Warn
What if we follow the logic - Is loglevel less than tracelevel?
yes - concise
no - verbose
Feel free to correct me if I miss something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case of Warn (or Error), traces will not be displayed in any form. This will work like next
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to always inject some tracing because without it we won't get connection id in logs from chain elements.
Signed-off-by: Artem Glazychev <[email protected]>
9ed89b4
to
e971fa7
Compare
rv, err := t.traced.Register(ctx, in, opts...) | ||
if err != nil { | ||
return nil, logError(ctx, err, operation) | ||
if logrus.GetLevel() == logrus.TraceLevel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we have another level in the grpc metadata?
Signed-off-by: Artem Glazychev <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
…k@main PR link: networkservicemesh/sdk#1513 Commit: 256d2cc Author: Artem Glazychev Date: 2023-09-28 16:52:28 +0700 Message: - Add concise tracing (#1513) * Log rotated after 5 minutes in NSMgr / Registry (-draft implementation for networkservise) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-forwarder implementation) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-skip the same errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle errors) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-handle registry logs) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> Log rotated after 5 minutes in NSMgr / Registry (-clean up) Signed-off-by: Alexander Peretyatko <[email protected]> * improvements Signed-off-by: Artem Glazychev <[email protected]> * fix datarace Signed-off-by: Artem Glazychev <[email protected]> * fix unstable tests Signed-off-by: Artem Glazychev <[email protected]> * fix registry span Signed-off-by: Artem Glazychev <[email protected]> * show concise logs in all cases except TraceLevel Signed-off-by: Artem Glazychev <[email protected]> * take into account grpcmetadata Signed-off-by: Artem Glazychev <[email protected]> --------- Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
LGTM |
Description
This PR adds concised logs. So we have:
- verbose - full logs (actually it is our current implementation from main branch). Activated at logrus
TraceLevel
andlog.EnableTracing(true)
- concise - short logs - log only the beginning and end of the Request. Activated at logrus
InfoLevel or DebugLevel
andlog.EnableTracing(true)
Examples (cmd-forwarder-vpp):
Full log
Short log
Issue link
networkservicemesh/deployments-k8s#9726
Closes: #1506
How Has This Been Tested?
Types of changes