-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequestFactory: simplified #31
base: master
Are you sure you want to change the base?
Conversation
+1 never used it. |
I also did not manage to find a server where |
@dg Can I remove the URL filters? They are magical and people who know about them prefer to turn them off anyway – see http://forum.nette.org/cs/9903-ne-kanonizace-lomitek-v-url or https://twitter.com/JanTvrdik/status/542389794085404673 Or does it fall into the same category as binary mode? |
ad ad filters: their problem is that they do not work with canonicalization… Filters are not used because nobody knows about them, they are hard to set, but they are useful. For example, they fix bad url parsers (like this), so it would be better to figure out how to solve the canonicalization. |
…PT_FILENAME (BC break) see #31 Conflicts: src/Http/RequestFactory.php
Partially merged by 37971f0 |
e6f0643
to
d6d5cc2
Compare
ad filters: I'm aware of what they can do, I'm just saying that nobody is using them for that. Even your websites don't use them. Wouldn't it be better to handle those use-cases in routing instead of |
0bb4336
to
96b498c
Compare
6df6a37
to
f17b437
Compare
f3ed3a1
to
f09472f
Compare
2a0c595
to
4ca7b03
Compare
da24b94
to
540335c
Compare
e7c7e2d
to
bf945f3
Compare
9a14e6e
to
a20fb8f
Compare
55488bd
to
2042d2e
Compare
4960652
to
5e67add
Compare
689f4ae
to
33aae19
Compare
$_SERVER['ORIG_PATH_INFO']
because I don't know any HTTP server used in real-world which would actually require this