FEATURE: Introduce PHPStan level 8 for CI

.github/workflows/tests.yml

@@ -86,12 +86,18 @@ jobs:
         git -C ../${{ env.PACKAGE_FOLDER }} checkout -b build
         composer config repositories.package '{ "type": "path", "url": "../${{ env.PACKAGE_FOLDER }}", "options": { "symlink": false } }'
         composer require --no-update --no-interaction neos/redirecthandler-neosadapter:"dev-build as dev-${PACKAGE_TARGET_VERSION}"
+        composer require --dev --no-update --no-interaction phpstan/phpstan:^1.11
 
     - name: Composer Install
       run: |
         cd ${NEOS_BASE_FOLDER}
         composer update --no-interaction --no-progress
 
+    - name: Linting
+      run: |
+        cd ${NEOS_BASE_FOLDER}/Packages/Application/Neos.RedirectHandler.NeosAdapter
+        composer run lint:phpstan
+
     - name: Setup Flow configuration
       run: |
         cd ${NEOS_BASE_FOLDER}

Classes/CatchUpHook/DocumentUriPathProjectionHook.php

@@ -161,7 +161,7 @@ private function handleNodePropertiesWereSet(NodePropertiesWereSet $event, \Clos
                 continue;
             }
 
-            $closure($node,  NodeAddress::create($this->contentRepository->id, $event->workspaceName, $affectedDimensionSpacePoint, $node->getNodeAggregateId()));
+            $closure($node, NodeAddress::create($this->contentRepository->id, $event->workspaceName, $affectedDimensionSpacePoint, $node->getNodeAggregateId()));
 
             $descendantsOfNode = $this->getState()->getDescendantsOfNode($node);
             array_map(fn (DocumentNodeInfo $descendantOfNode) => $closure(

composer.json

@@ -10,6 +10,7 @@
         "neos/flow": "^9.0"
     },
     "scripts": {
+        "lint:phpstan": "../../../bin/phpstan analyse",
         "test:behat-cli": "../../../bin/behat -f progress --strict --no-interaction",
         "test:behavioral:stop-on-failure": "@test:behat-cli -c Tests/Behavior/behat.yml.dist -vvv --stop-on-failure"
     },

phpstan.neon.dist

@@ -0,0 +1,4 @@
+parameters:
+    level: 8
+    paths:
+        - Classes