Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: remove Neos.NodeTypes package #526

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

FEATURE: remove Neos.NodeTypes package #526

wants to merge 9 commits into from

Conversation

crydotsnake
Copy link
Member

resolves: #524

@crydotsnake crydotsnake marked this pull request as draft August 14, 2023 11:57
@crydotsnake
Copy link
Member Author

I will add more description later. Since I'm not finished with this PR yet 🙂

@crydotsnake crydotsnake self-assigned this Aug 14, 2023
@crydotsnake
Copy link
Member Author

crydotsnake commented Aug 14, 2023 •
edited
Loading

Should we translate the content elements? or should we use English labels and placeholders by default? wdyt? @Sebobo

@mhsdesign
Copy link
Member

I wouldn't translate it. Its imo only for us, and we know english ^^

@tschoeki
Copy link
Collaborator

I'd rather suggest rearranging the content elements by usage/usefulness and not by randomness like it is now :D

@crydotsnake
Copy link
Member Author

Thanks for your Feedback !

@tschoeki definetly ! And #525 is an important part of that :)

@Sebobo
Copy link
Member

Sebobo commented Aug 15, 2023

No translation necessary.

@crydotsnake
Copy link
Member Author

FYI:

I will always migrate one element, and then commit the changes everytime if everything looks okay. So i dont lose control. Just in case you want too disable the email notifications for this PR 🙂

@Sebobo
Copy link
Member

Sebobo commented Sep 28, 2023

Hi @crydotsnake how is the status here? Want to cleanup the list of PRs a bit.

@crydotsnake
Copy link
Member Author

Hi @Sebobo !

Unfournatley it is still not finished. Had no time continue working on that so far.

@crydotsnake crydotsnake force-pushed the feature/remove-neos-nodetypes-package branch from fc9ad7a to a850b88 Compare October 20, 2023 15:01
@crydotsnake crydotsnake added the WIP Work in Progress label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crydotsnake crydotsnake

Labels
enhancement WIP Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of Neos.NodeTypes package
4 participants
@crydotsnake @mhsdesign @tschoeki @Sebobo