Handle https://github.com/neo-project/neo/pull/3520 #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We better just do #3517 solving this and many other potential problems. |
I agree. Yet we can still do more to avoid GC. I have changed my strategy in this PR. We can check every dropped compound item to avoid graph searches. |
Jim8y
reviewed
Oct 11, 2024
src/Neo.VM/ExecutionEngine.cs
Outdated
| @@ -288,7 +288,7 @@ public T Pop<T>() where T : StackItem | |||
| /// </summary> | |||
| protected virtual void PostExecuteInstruction(Instruction instruction) | |||
| { | |||
| if (ReferenceCounter.Count < Limits.MaxStackSize) return; | |||
| if (ReferenceCounter.Count <= Limits.MaxStackSize) return; | |||
There was a problem hiding this comment.
please make this one a seperate pr.
There was a problem hiding this comment.
I am still considering it. If <= is not applied, this PR makes no sense.
There was a problem hiding this comment.
I am still considering it. If <= is not applied, this PR makes no sense.
you can make <= merhged first, then do this pr. If you mixed together, will be slower to review since it contains two different purposes.
Jim8y
reviewed
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles
VwEAwkpKAfoHdwARwG8AnXcAbwAl9////xHAzwJwlAAAdwDBwG8AnXcAbwAl9////0U=Type of change
How Has This Been Tested?
invoke script
VwEAwkpKAfoHdwARwG8AnXcAbwAl9////xHAzwJwlAAAdwDBwG8AnXcAbwAl9////0U=Should finish in 0.4s when #3520 is merged.
Checklist: