fix: Remove blue on button, select on iOS 15+ Safari #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS 15+ devices the button text color has changed to blue (via color: -apple-system-blue;). This is a change from iOS 14- devices which displayed black. While all browsers display buttons slightly differently I felt the blue change was significant enough to warrant a reset as developers might not be expecting this.
Nightcaat
approved these changes
May 16, 2022
|
Adding this to my normalize in https://github.com/garrettw/vitals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
On iOS 15+ devices the button text color has changed to blue (via a user-agent style
color: -apple-system-blue;).This is a change from iOS 14- devices which displayed black. While all browsers display buttons slightly differently I felt the blue change was significant enough to warrant a reset as developers might not be expecting this. But I'm also not sure if this is too opinionated for normalize or not, what do you think?
I've put below screenshots of the browsers I have to hand to test on but theres a few key ones missing like IE.
This is my first contribution, I've checked the contributing guidelines and I think I've got everything correct but if theres anything at all let me know 👍
Thanks! 💛