Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed overflow: visible to overflow: hidden for hr element #861

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed overflow: visible to overflow: hidden for hr element #861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bdcaad
Changed overflow visible to hidden of hr element
costingh Jul 15, 2021
4a8722a
fixed comment for hr element
costingh Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions normalize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ h1 {

/**
* 1. Add the correct box sizing in Firefox.
* 2. Show the overflow in Edge and IE.
* 2. Hide the overflow in Edge and IE.
*/

hr {
box-sizing: content-box; /* 1 */
height: 0; /* 1 */
overflow: visible; /* 2 */
overflow: hidden; /* 2 */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change the comment on line number 50 is now incorrect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I need to look into more detail

Copy link
Author

@costingh costingh Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the comment. Hope it is ok now :)

Copy link

@nosilleg nosilleg Jul 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the comment it would appear that Edge and IE were following spec and all other browsers weren't. So your change to the comment is still not accurate.

I'm not a maintainer so I don't know what the full expectations are for this, but for me personally I would expect the comment to reference the browsers that show overflow. This requires testing. If there are no browsers that are still showing overflow then the code change should be to remove the lines, not to change the value to "hidden". If there are still browsers showing overflow then it would be good to have that list so that eventually the code can be removed from this repo when they all follow spec.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to my normalize in https://github.com/garrettw/vitals until I know it's not needed anymore.

}

/**
Expand Down