Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for workbench-dev role in addition to group #28

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Jan 11, 2024

Problem

Sometimes Keycloak Groups aren't mapped properly?

Unclear if this is due to configuration error, or something else

Approach

  • fix: fallback to checking Role name (in addition to group name)

How to Test

  1. Checkout and run this branch locally (see workbench-helm-chart)
  2. Navigate to https://kubernetes.docker.internal/ (ignore browser certificate warnings)
  3. Login/register with Keycloak
    • You should be brought back to the Workbench, now logged in
  4. Edit your user in Keycloak to have the workbench-dev role (optionally, without the group)
  5. Add an application from the "All Apps"
    • You should be brought to "My Apps" to see your new app
    • You should see an "Edit" (pencil) icon beside the Launch button
  6. Click the Edit button
    • You should see the "Edit Service" page loads
    • You should see this offers you a way to set custom envvars for the application

@bodom0015 bodom0015 merged commit 95df3f6 into develop Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant