ControllerAction: use dynamic params on oscillation detection #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corot
requested review from
ChristofDubs,
spuetz,
siferati and
RainerKuemmerle
corot
force-pushed
the
controller_oscillation_params
branch
2 times, most recently
from
15e38cb
to
8ccb7bb
Compare
siferati
approved these changes
Nov 26, 2023
…eBaseAction does)
Co-authored-by: Tiago Silva <[email protected]>
corot
force-pushed
the
controller_oscillation_params
branch
from
d5db1c6
to
d15bbdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as MoveBaseAction does
I have renamed AbstractActionBase::reconfigureAll as AbstractActionBase::reconfigure, so any action that needs dynamic parameters can just override it (as ControllerAction does now)