Issues/37 Add function for returning an iterator instead of sequence #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the confusion @chuckwondo ... this should incorporate all the suggested changes from #89 |
chuckwondo
reviewed
Sep 24, 2024
chuckwondo
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks @frankinspace! I'm approving, but if you're not opposed, I've made a nit-picky request for adding some blank lines in the changelog for editing readability.
Co-authored-by: Chuck Daniels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37
Reopened accidental merge from #89
Added a new function
resultswhich returns an iterator that will yield all hits by default. Optional parameters for controlling the limit and page size are also available.Deprecated the
get_allin favor ofresults.Deprecated
getin favor ofresults.Updated the unit tests to have equivalent tests for the new
resultsfunction. Also updated the usage of vcrpy so that cassettes are named for the test function.