CMR-9848: When submitting multiple associations, if one fails CMR returns a 400 but still makes the other associations

[sxu123]

Overview

What is the feature/fix?

Return proper status when processing association requests.

What is the Solution?

When processing association request, only return 400 status when ALL associations fail, rather than when ANY association fails. This includes all generic associations and regular associations, except for tag association. When I changed tag associations return status from 400 to 200 with only partial failure, for some mysterious reason, some ACL related stuff failed in the build, which I really don't see any connection with the fix. I'm writing a separate ticket for the tag association part since I don't have time to fix it.

What areas of the application does this impact?

CMR search.

Checklist

• [x ] I have updated/added unit and int tests that prove my fix is effective or that my feature works
• [ x] New and existing unit and int tests pass locally and remotely
• clj-kondo has been run locally and all errors corrected
• I have removed unnecessary/dead code and imports in files I have changed
• [x ] I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [x ] I have made corresponding changes to the documentation
• [ x] My changes generate no new warnings
• I have cleaned up integration tests by doing one or more of the following:
  • migrated any are2 tests to are3 in files I have changed
  • de-duped, consolidated, removed dead int tests
  • transformed applicable int tests into unit tests
  • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.14%. Comparing base (a639272) to head (3c38e61).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...rch-app/src/cmr/search/api/generic_association.clj	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2174      +/-   ##
==========================================
- Coverage   58.15%   58.14%   -0.01%     
==========================================
  Files        1045     1045              
  Lines       70428    70430       +2     
  Branches     2001     1998       -3     
==========================================
- Hits        40959    40954       -5     
- Misses      27610    27612       +2     
- Partials     1859     1864       +5     

Flag	Coverage Δ
	24.43% <37.50%> (-33.73%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eudoroolivares2016]

Suggested change

	HTTP/1.1 400 Bad Request
	HTTP/1.1 200 Bad Request```
	Isn't this example also `200` since the `C1200000005-PROV1` in the example would have succeeded?