Allow HTTP (localhost only) for IDPortenUri #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the OPaaS-slack.
For local development it can be nice to allow http as a URL to ID-porten (for things like post-login-uri etc). But since the general rule should be to only use HTTPS, this pattern will only allow HTTP if it is on localhost. This means we would not need to use self-signed certificate to do local development with authentication enabled.
DigDir does not allow
http
in production, but for test-clients it is allowed.This pattern will match URIs that either start with
https://
orhttp://localhost:
(i added the requirement to add:
which is usually followed by a port to make sure it did not match domains that just start with the wordlocalhost
like "localhost.com")It will not match URIs like: