Merge pull request #294 from nacos-group/dev

release v1.3.6
nacos-group · Jun 27, 2024 · 42fb0b5 · 42fb0b5
2 parents 81d54b2 + 4359f77
commit 42fb0b5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -42,7 +42,7 @@ https://nacos-sdk-csharp.readthedocs.io/en/latest/
 // after v1.3.3, we can use UseNacosConfig to simplify
 public static IHostBuilder CreateHostBuilder(string[] args) =>
     Host.CreateDefaultBuilder(args)
-        .UseNacosConfig(section: "NacosConfig", parser: null logAction: null)
+        .UseNacosConfig(section: "NacosConfig", parser: null, logAction: null)
         // .UseNacosConfig(section: "NacosConfig", parser: Nacos.YamlParser.YamlConfigurationStringParser.Instance logAction: null)
         // .UseNacosConfig(section: "NacosConfig", parser: Nacos.IniParser.IniConfigurationStringParser.Instance logAction: null)       
         .ConfigureWebHostDefaults(webBuilder =>

diff --git a/README.zh-cn.md b/README.zh-cn.md
@@ -44,7 +44,7 @@ https://nacos-sdk-csharp.readthedocs.io/en/latest/
 // v1.3.3 版本之后, 可以用 UseNacosConfig 来简化
 public static IHostBuilder CreateHostBuilder(string[] args) =>
     Host.CreateDefaultBuilder(args)
-        .UseNacosConfig(section: "NacosConfig", parser: null logAction: null)
+        .UseNacosConfig(section: "NacosConfig", parser: null, logAction: null)
         // .UseNacosConfig(section: "NacosConfig", parser: Nacos.YamlParser.YamlConfigurationStringParser.Instance logAction: null)
         // .UseNacosConfig(section: "NacosConfig", parser: Nacos.IniParser.IniConfigurationStringParser.Instance logAction: null)       
         .ConfigureWebHostDefaults(webBuilder =>

diff --git a/build/version.props b/build/version.props
@@ -1,5 +1,5 @@
 <Project>
     <PropertyGroup>
-        <NugetVersion>1.3.5</NugetVersion>
+        <NugetVersion>1.3.6</NugetVersion>
     </PropertyGroup>
 </Project>
diff --git a/src/Nacos/V2/Config/Impl/ConfigRpcTransportClient.cs b/src/Nacos/V2/Config/Impl/ConfigRpcTransportClient.cs
@@ -334,6 +334,7 @@ protected async override Task ExecuteConfigListen()
         {
             var listenCachesMap = new Dictionary<string, List<CacheData>>();
             var removeListenCachesMap = new Dictionary<string, List<CacheData>>();
+            var hasChangedKeys = false;
 
             // TODO: should update logic here.....
             foreach (var item in _cacheMap.Values)
@@ -392,6 +393,7 @@ protected async override Task ExecuteConfigListen()
 
                                 if (configChangeBatchListenResponse.ChangedConfigs != null && configChangeBatchListenResponse.ChangedConfigs.Any())
                                 {
+                                    hasChangedKeys = true;
                                     foreach (var item in configChangeBatchListenResponse.ChangedConfigs)
                                     {
                                         var changeKey = GroupKey.GetKeyTenant(item.DataId, item.Group, item.Tenant);
@@ -450,6 +452,9 @@ protected async override Task ExecuteConfigListen()
                     }
                 }
             }
+
+            if (hasChangedKeys)
+               await NotifyListenConfig().ConfigureAwait(false);
         }
 
         private async Task RefreshContentAndCheck(string groupKey, bool notify)