example: add apollo-client todo app #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
changed the title
n1ru4l
commented
Oct 8, 2020
| @@ -27,8 +27,8 @@ | |||
| "main": "dist/index.cjs.js", | |||
| "module": "dist/index.esm.js", | |||
| "exports": { | |||
| "require": "dist/index.cjs.js", | |||
| "default": "dist/index.mjs" | |||
| "require": "./dist/index.cjs.js", | |||
There was a problem hiding this comment.
Node 12 and VSCode IDE complained about this not being prefixed (could not resolve module), however, bob complained about this being prefixed. I commented the lines out for now. Gotta check whether this is an issue that should be fixed in bob.
n1ru4l
force-pushed
the
feat-apollo-client-todo-example
branch
from
1ec8ae2
to
3ba933d
Compare
n1ru4l
commented
Oct 8, 2020
Comment on lines
+6
to
+26
| class SocketIOGraphQLApolloLink extends ApolloLink { | ||
| private networkLayer: SocketIOGraphQLClient; | ||
| constructor(networkLayer: SocketIOGraphQLClient) { | ||
| super() | ||
| this.networkLayer = networkLayer; | ||
| } | ||
|
|
||
| public request(operation: Operation): Observable<FetchResult> | null { | ||
| const sink = this.networkLayer.execute({ | ||
| operationName: operation.operationName, | ||
| operation: print(operation.query), | ||
| variables: operation.variables | ||
| }); | ||
|
|
||
| return sink as Observable<FetchResult> | ||
| } | ||
| } | ||
|
|
||
| export const createApolloClient = ( | ||
| networkInterface: SocketIOGraphQLClient | ||
| ) => { |
There was a problem hiding this comment.
This is the most important part, the glue code between the SocketIOGraphQLClient and ApolloClient :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146