-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension plugin support #162
Merged
ahankinson
merged 93 commits into
music-encoding:develop
from
notengrafik:pr/finalize-extensions
Feb 16, 2021
Merged
Extension plugin support #162
ahankinson
merged 93 commits into
music-encoding:develop
from
notengrafik:pr/finalize-extensions
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libmei methods aren't found yet
Using dictionaries in the proper way helps...
Composer label, subtitle, subscript and superscript
Was added in a WIP commit (7ffe10b), but it was never used
Speeds up processing and fixes music-encoding#119
+ documentation
This is how we recommend extensions to behave
ahankinson
reviewed
Feb 5, 2021
Are there any objections about this PR? If not, I would like to merge it maybe next week or so... |
I can merge it |
Thanks a lot! |
THank you (and @th-we ) for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@annplaksin and I worked on how to export custom symbols and text styles as sensible MEI, without having to fork Sibmei. For this, we reworked the entire text and symbol export. This brings quite some substantial changes to the code, and the following benefits:
switch
es were replaced by declarative definitions of symbolsWe wrote documentation and an example.