Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS(build): Update Ubuntu package names #6205

Merged
merged 1 commit into from
Dec 29, 2023
Merged

DOCS(build): Update Ubuntu package names #6205

merged 1 commit into from
Dec 29, 2023

Conversation

kaifkh20
Copy link
Contributor

@kaifkh20 kaifkh20 commented Sep 20, 2023 •
edited by Krzmbrzl
Loading

Fixes #6204

Checks

@davidebeatrici
Copy link
Member

qt5-qmake may be unneeded, if the CMake module doesn't rely on files that are provided by it.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Sep 20, 2023 •
edited
Loading

if the CMake module doesn't rely on files that are provided by it.

I don't think it does 🤔

@kaifkh20 please make sure your commits conform with our commit guidelines (for that they also have to be squashed)

@kaifkhan1
Copy link

Sorry for the inconvenience.
I might have made this PR in a hurry.

@Krzmbrzl
Copy link
Member

No worries - it's nothing that can't be fixed :)

@Krzmbrzl Krzmbrzl changed the title Replaced qt5-default with qtbase5-dev and qt5-qmake DOCS(build): Update Ubuntu package names Dec 29, 2023
@Krzmbrzl Krzmbrzl merged commit fd41ebd into mumble-voip:master Dec 29, 2023
16 checks passed
@Krzmbrzl
Copy link
Member

Thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krzmbrzl Krzmbrzl Krzmbrzl approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package 'qt5-default' has no installation candidate
4 participants
@kaifkh20 @davidebeatrici @Krzmbrzl @kaifkhan1