Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quick Connect button #3843

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Fernando-A-Rocha
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha commented Nov 6, 2024

This PR is a substitute for abandoned PR #2813

Resolves #2469

  • Removes _beta_qc_rightclick_command setting (there was a comment saying it was beta and could change at any time, so there you go lmao)
  • Removes old qc_host, qc_port and qc_password settings
  • Displays in the window Reconnecting to instead of Connecting to when reconnecting to a server
  • Shows reconnect: instead of connect: in the console for reconnect cmd
  • Alters the Quick Connect button behavior: Left-click executes reconnect command, Right-click opens the Server Browser on the Local tab, instructing you how to type an IP and Port to connect

This button logic makes more sense, as the majority wants the main feature to be connecting to the last IP:Port, and not opening the server browser to do it manually.

Tested.
Ready.

@TheNormalnij TheNormalnij added the enhancement New feature or request label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or Replace Quick Connect button
3 participants