Fix #3738 createBuilding optional arguments not handled correctly

[FileEX]

Fix #3738

I think this is what the parser should take care of, that if the vector is optional, it should put 0 in the remaining fields

[TheNormalnij]

I don't think that original issue is valid. Developers should provide all vector arguments. It has more sense for me.

You fixes only one case of this issue. The main problem hides in argument parser.

[TracerDS]

I don't think that original issue is valid. Developers should provide all vector arguments. It has more sense for me.

You fixes only one case of this issue. The main problem hides in argument parser.

Its more of a logic issue. What do you expect vector to receive? 3 coordinates.
What happens when you dont provide all 3 coordinates? Error occurs.

[FileEX]

TheNormalnij is right. This should be fixed in the parser. Many functions rely on the syntax where each argument in [ ] is optional, such as createVehicle, createObject, etc. The method in the old parser, ReadVector3D, would simply insert 0 in place of any missing argument. The new parser should handle this as well, because the current behavior is confusing. In one function, you can provide a single argument, but in another, you have to provide all three, even though each one is marked as optional individually

[TracerDS]

TheNormalnij is right. This should be fixed in the parser. Many functions rely on the syntax where each argument in [ ] is optional, such as createVehicle, createObject, etc. The method in the old parser, ReadVector3D, would simply insert 0 in place of any missing argument. The new parser should handle this as well, because the current behavior is confusing. In one function, you can provide a single argument, but in another, you have to provide all three, even though each one is marked as optional individually

for now lets just treat vectors as struct { float x,y,z; }

[Pirulax]

Should be an easy fix

TheNormalnij is right. This should be fixed in the parser. Many functions rely on the syntax where each argument in [ ] is optional, such as createVehicle, createObject, etc. The method in the old parser, ReadVector3D, would simply insert 0 in place of any missing argument. The new parser should handle this as well, because the current behavior is confusing. In one function, you can provide a single argument, but in another, you have to provide all three, even though each one is marked as optional individually

So, just default initialize values (CVector for example)?

[FileEX]

Should be an easy fix

TheNormalnij is right. This should be fixed in the parser. Many functions rely on the syntax where each argument in [ ] is optional, such as createVehicle, createObject, etc. The method in the old parser, ReadVector3D, would simply insert 0 in place of any missing argument. The new parser should handle this as well, because the current behavior is confusing. In one function, you can provide a single argument, but in another, you have to provide all three, even though each one is marked as optional individually

So, just default initialize values (CVector for example)?

The point is that if a function accepts std::optional<CVector>, we have to provide the entire vector, all three values, because otherwise, there's an error that says a vector was expected, but a number was received. It should work like in the old parser, where if, for example, two values fX and fY were provided, the fZ value would simply be set to 0 and treated as a valid vector

[Pirulax]

yeah thats what i meant
that should be easy