Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print the correct column difference when dataframe columns do not mat… #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print the correct column difference when dataframe columns do not mat… #23

wants to merge 1 commit into from

Conversation

AmirAl-Jumaily
Copy link

…ch schema columns

@multimeric
Copy link
Owner

Hi Amir, thanks for fixing this, it does look like a bug, considering columns is a list of strings and self.columns is not. I should add a type checker to detect issues like this.

Do you think you could add a minimal case of this error to the test suite? It would be very helpful for avoiding issues like this in the future.

multimeric
multimeric requested changes Oct 3, 2019
View reviewed changes
Copy link
Owner

@multimeric multimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multimeric multimeric multimeric requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmirAl-Jumaily @multimeric