-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update qemu-binfmt-conf.sh to support loongarch64 #189
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: zhangguanzhang <[email protected]>
@lafin PTAL |
@lafin What ideas do you have for supporting LoongArch? |
@@ -1,7 +1,7 @@ | |||
#!/bin/sh | |||
|
|||
QEMU_BIN_DIR=${QEMU_BIN_DIR:-/usr/bin} | |||
|
|||
QEMU_SUFFIX=${QEMU_SUFFIX:--static} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qemu-user-static
shoud be statically linked. Simply rename qemu-user
to qemu-user-static
will not work as expected. So -static
suffix is not optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qemu-user-static
shoud be statically linked. Simply renameqemu-user
toqemu-user-static
will not work as expected. So-static
suffix is not optional.
This was the default behavior before. I just added the variable default value so that it can be configured through variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the default value should be changed. -static
is necessary for binfmt
to work properly.
@zhangguanzhang Could you update the commit? QEMU 9.1 has been released. |
Fixes: #188