Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant import #119

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

danieleades
Copy link

@danieleades danieleades commented Mar 1, 2024

This change is Reviewable

@faern faern self-requested a review March 1, 2024 14:30
@danieleades danieleades force-pushed the redundant-import branch 2 times, most recently from 9de60ac to 5745187 Compare March 1, 2024 14:31
@faern faern merged commit 37f183c into mullvad:main Mar 1, 2024
10 checks passed
@faern
Copy link
Member

faern commented Mar 1, 2024

Thank you for this fix! Was just about to do it myself. Github actions seem to have some issues, so I did not even wait for it to complete. Could you please rebase your other PR on latest main now? Please mind that I force-pushed main to be able to sign your commit.

@danieleades
Copy link
Author

Thank you for this fix! Was just about to do it myself. Github actions seem to have some issues, so I did not even wait for it to complete. Could you please rebase your other PR on latest main now? Please mind that I force-pushed main to be able to sign your commit.

ah i see. i think that has the effect of not giving me 'credit' for the commit, hence actions are not triggering automatically on my PRs

@danieleades danieleades deleted the redundant-import branch March 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants