Pin mingw version in workflow #110
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
.github/workflows/build-and-test.yml line 38 at r1 (raw file):
Can you please add a comment about why we specify the version. Very hard to infer from just reading the yml file. Something like:
Pinning a working version of MinGW since we have seen issues with newer versions
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @faern)
.github/workflows/build-and-test.yml line 38 at r1 (raw file):
Previously, faern (Linus Färnstrand) wrote…
Can you please add a comment about why we specify the version. Very hard to infer from just reading the yml file. Something like:
Pinning a working version of MinGW since we have seen issues with newer versions
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There's an issue with the
setup-mingwaction for newer versions of mingw: https://github.com/mullvad/windows-service-rs/actions/runs/6889525757/job/18745989633?pr=109Let's use an older version of mingw until that has been fixed.
This change is