Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix TOC RTL padding regression #44535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 24, 2024

This fixes a regression introduced in #42498. This is broken in RTL:

SCR-20241124-otps

Before: https://deploy-preview-42498--material-ui.netlify.app/material-ui/react-button/
After: https://deploy-preview-44535--material-ui.netlify.app/material-ui/react-button/

Off-topic. Speaking of regressions, spending some time on this made me realize the dark mode and RTL toggle have an important performance regression: #44534.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product labels Nov 24, 2024
@mui-bot
Copy link

mui-bot commented Nov 24, 2024

Netlify deploy preview

https://deploy-preview-44535--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 427b70b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants