[icons] Improve icon search performance #44450
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
icon-search-performance
branch
2 times, most recently
from
2c3147d
to
38602c3
Compare
Netlify deploy previewhttps://deploy-preview-44450--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
icon-search-performance
branch
from
38602c3
to
e52845e
Compare
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #44001. I'm not sure that that change actually had any positive impact. I suspect that it only surfaced a Chrome DevTools bug that it works around.
Instead, what we see now is https://pagespeed.web.dev/analysis/https-mui-com-material-ui-material-icons/cvfn967l26?form_factor=desktop. That INP is horrible.
What I'm doing instead is moving #44025 to the finish line. I used a different search dependency at the same time. It seems smaller, faster, and a bit more accurate.
I was curious to check how other icons libraries handle this:
Preview: https://deploy-preview-44450--material-ui.netlify.app/material-ui/material-icons/