Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the possibility to include headers using target #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igorsnunes
Copy link

Description

In order to use the target_link_directories on an external project, an extra statement had to be added to the target_include_directories, as shown on the diff. If that is not done, the restclient_cppTarges.cmake file will not contain the INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include" statement, under set_target_properties. As a consequence, it won't be possible to include the headers on my project using:

target_include_directories(${LibName} PRIVATE restclient-cpp)

  • CI passes
  • Description of proposed change
  • Documentation (README, code doc blocks, etc) is updated
  • Existing issue is referenced if there is one
  • Unit tests for the proposed change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant