Unittest redesign #58
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 359 355 -4
=====================================
- Hits 359 355 -4
Continue to review full report at Codecov.
|
avoid collision with libinsanity macro naming
Some tests got duplicated, one version may removed eventually. It is probably good idea to keep changes to libinsanity as small as possible to allow future merging Some tests did discover printf bugs/inconsistencies and are failing intentionally
move code into separate scope
Considerably reduces compilation time. gcc seems to have problems with multiple tests reusing variables
|
Hello. The coverage report is strange - missing line is always-false branch dependent on type size (sizeof(uintptr_t) == sizeof(long long);), it shouldn't be covered even before this change, but c++ is probably optimizing a bit even with |
| idx = _ntoa_long(out, buffer, idx, maxlen, (unsigned long)((uintptr_t)va_arg(va, void*)), false, 16U, precision, width, flags); | ||
| #if defined(PRINTF_SUPPORT_LONG_LONG) | ||
| } | ||
| #if defined(PRINTF_SUPPORT_LONG_LONG) && (LONG_MAX < UINTPTR_MAX) |
There was a problem hiding this comment.
The test should be if defined(PRINTF_SUPPORT_LONG_LONG) && (ULONG_MAX < UINTPTR_MAX). The current test selects the long long code even for 32-bit pointers on targets with 32-bit longs as LONG_MAX < ULONG_MAX is always true. Writing this comparison as (UINTPTR_MAX > ULONG_MAX) might be more readable.
|
@ledvinap : So, some of these changes aren't strictly about the unit tests, and are covered by other PRs. Also, if you check out my fork, you'll notice I've merged some of those proposed changes, as this repo has not seen much traction for a while. If you're interested - I would appreciate PR against that fork. |
…of the source files into a library-specific subdirectory, as per mpaland#58, there is no longer the risk of clashing with glibc's `printf.h`, so the test programs can use `<foo.h>`-style inclusion rather than `"../path/to/foo.h"`-style.
Build printf using C
Convert most tests in test_suite to use macro
Fix catch2
New tests use CHECK now, but it may be reverted easily back to REQUIRE.