Merge pull request #248 from garygreen/fix/length-undefined

Fix undefined variables throwing exception with length filter
mozilla · Aug 15, 2014 · 3c25b95 · 3c25b95
2 parents 99c4b78 + 17d5735
commit 3c25b95
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/filters.js b/src/filters.js
@@ -149,7 +149,7 @@ var filters = {
     },
 
     length: function(arr) {
-        return arr.length;
+        return arr !== undefined ? arr.length : 0;
     },
 
     list: function(val) {

diff --git a/tests/filters.js b/tests/filters.js
@@ -183,6 +183,11 @@
             finish(done);
         });
 
+        it('length handle undefined variables', function(done) {
+          equal('{{ blah|length }}', '0');
+          finish(done);
+        });
+
         it('list', function(done) {
             equal('{% for i in "foobar" | list %}{{ i }},{% endfor %}',
                   'f,o,o,b,a,r,');