Do not send extra channels for aggregate devices. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Pehrsons , who I've been working with on this. You may want to do more extensive testing here; I've only tested one combination of input/output devices. |
|
I believe the test failures are the same as on ToT, but I'm not sure if there are any new problems here. |
Pehrsons
requested changes
Nov 14, 2024
After f8df86f, we drop the **first** several channels if there are extras (e.g. for aggregate devices). This is often incorrect (because the first device is the input device), and also is inefficient.
mutexlox-signal
force-pushed
the
mutexlox/aggregate
branch
from
85b055a
to
5594cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We drop the first several channels if there are extras (e.g. for aggregate devices) After f8df86f, this is often incorrect
(because the first device is the input device), and also is inefficient.
So, only request the channels we're planning to use.