SFTP client for CatalistMatch has 10 minute timeout #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunagm
reviewed
Oct 15, 2024
In my experience, that's right. The timeout doesn't actually check for the download to complete within that amount of time, but rather will trigger if the server hasn't sent back any new packets in that amount of time. |
|
Ok, I'm going to label it a breaking change just so I remember to highlight it in the release notes. Will go ahead and update branch then merge once the tests pass again. |
shaunagm
added
the
breaking change
shaunagm
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important because sometimes the Catalist sftp server hangs indefinitely.