Utility: handle Path::{configuration,home}Directory() failures on Windows #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dows. These can happen on system accounts without a home folder, for example. Seems like I didn't read the documentation properly when I made this into an assert in e1e813e. Original code had a *silly* check for the appdata path being empty, and since e1e813e failing in that case, but the check dates back to e1e813e from 2011, and unfortunately I don't remember what was the logic behind it back then. Windows XP compatibility or some such? Instead, it's now morphed into checking the result of SHGetFolderPathW(). Hopefully that won't cause some other regression again.
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 124 124
Lines 9504 9504
=======================================
Hits 9352 9352
Misses 152 152
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #132, waiting on confirmation from @Squareys. Things to do: