Remove unused properties #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Smalltalk importer is adding some properties to the methods but those are flushable. So either we need to make them permanent or to remove them. Since I've never seen anyone use those 2 propoerties I propose to remove them.
Gabriel-Darbord
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Smalltalk importer is adding some properties to the methods but those are flushable. So either we need to make them permanent or to remove them.
Since I've never seen anyone use those 2 propoerties I propose to remove them.
One is the number of super sent in a method calling the overriden method. The second is the number of super send to another method. To me this should be for FAST and not Famix