Add 'Community creation' warning #1244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h serial >=100000 Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
limpkin
reviewed
Sep 18, 2024
src/MainWindow.ui
Outdated
| @@ -7,7 +7,7 @@ | |||
| <x>0</x> | |||
| <y>0</y> | |||
| <width>946</width> | |||
| <height>632</height> | |||
| <height>1081</height> | |||
There was a problem hiding this comment.
i think that's a problem.... @deXol ?
There was a problem hiding this comment.
I don't remember explicitly changing these sizes, must be qt creator's doing. Will double-check tomorrow.
src/MainWindow.ui
Outdated
| <width>770</width> | ||
| <height>882</height> | ||
| <width>932</width> | ||
| <height>1832</height> |
src/MainWindow.ui
Outdated
| <width>646</width> | ||
| <height>885</height> | ||
| <width>524</width> | ||
| <height>704</height> |
|
thanks a lot @nekromant !!! It's really appreciated. |
|
Obligatory screenshot of how it looks like with a homebrew device:
|
Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a few mini bles for me and friends based on the available specs. As @limpkin suggested I used serial numbers >= 100000 for them. To avoid any frustration (in case any of the devices end up on ebay), I suggest treating any devices with serial number >=100000 as 'community creations'. For them:
The translation files are updated yet again, I've added relevant Russian translation for the new messages and (hopefully) not too ugly German one. (The latter one needs some checking by some native speaker though, my knowledge of German is pretty bad).