Switch from Psalm to PHPStan level 6 #803
Conversation
ruudk
changed the title
|
@frederikbosch I was able to bring it to level 6. I cannot really spend more time on it, but I think this is a good starting point. I replaced all |
|
Damn, that must have been quite some work. Fantastic work. I will schedule my review soon. |
|
I'm not really the right person to approve this these days, so I'll just leave a couple emojis here to salute your effort ✅ 🎉 |
🍾 🥂 ❤️
|
I couldn't find any real code changes that were required for this change. Changes that were included were code removals. So I believe there is no reason why not merging this PR, is there? |
| $currencyIterator = $currencies->getIterator(); | ||
| /** @psalm-var AppendIterator&Traversable<int|string, Currency> $currencyIterator */ | ||
| $iterator->append($currencyIterator); | ||
| $iterator->append(new IteratorIterator($currencies->getIterator())); |
There was a problem hiding this comment.
@frederikbosch This was the only code change, but I think it's fine, as the test also passes.
|
@frederikbosch There is only 1 line changed, but I think that's fine. Let's ship this |
Needs #802
Fixes #798