Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Psalm with PHPStan #798

Open
ruudk opened this issue Sep 12, 2024 · 5 comments · May be fixed by #803
Open

Switch Psalm with PHPStan #798

ruudk opened this issue Sep 12, 2024 · 5 comments · May be fixed by #803

Comments

@ruudk
Copy link
Contributor

ruudk commented Sep 12, 2024

Currently, Psalm blocks testing this on PHP 8.4 #796 .

I also wonder why the package uses Psalm, as PHPStan feels much more alive than Psalm.
@frederikbosch
Copy link
Member

Why would Psalm be blocking that? I don't see any failed tests because of it.

@ruudk
Copy link
Contributor Author

ruudk commented Sep 12, 2024

Because I added --platform-ignore-reqs=php to the PR in the meantime.

@frederikbosch
Copy link
Member

Oh, I did not do a good review then, that's a blocker.

@frederikbosch
Copy link
Member

frederikbosch commented Nov 22, 2024 •
edited
Loading

It's not a bad idea to switch to PHPStan. The contributions to Psalm are not what it has been, while PHPStan has recently released version 2. There is also no urgency in the Psalm project to support PHP 8.4 which stops us at the moment from supporting 8.4.

So, if anyone would like to contribute the switch, I would love to help. I lack the time at the moment to create the PR myself.

@ruudk
Copy link
Contributor Author

ruudk commented Nov 22, 2024

@frederikbosch 🫡 challenge accepted

@ruudk ruudk linked a pull request Nov 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from Psalm to PHPStan level 6 ruudk/money
2 participants
@ruudk @frederikbosch