Fix: new std feature to handle std error trait #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #39
no_std
should be opt out. Before releasing1.1.0
I didn't realize we would break compatibility with all dependent crates becausestd::error::Error
implemented throughthiserror
was removed.core::error::Error
is nightly for now so we can't make it work without this newstd
feature. For now I prefer usingthiserror
to handle derivation for us, it's common and 1 liner instead of manually keeping the implementation ofError::source
.Today I'm wondering if
1.1.1
is ok, but breaking dependents with:{ version = "1", default-features = false }
or if2.0.0
is necessary. For the later I'd then removecheck
from default as this was a bad idea from the beginning.@mangoplane would you check that we are equivalent in a
no_std
environment as in #39