Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v24.01 Release Candidate #26

Merged
merged 0 commits into from
Jan 17, 2024
Merged

v24.01 Release Candidate #26

merged 0 commits into from
Jan 17, 2024

Conversation

chrisandreae
Copy link
Collaborator

@chrisandreae chrisandreae commented Jan 4, 2024

Rebases to ZMK upstream as of 0e2f94b (2024-01-03).

  • Replaces custom peripheral battery reporting with upstream implementation, and now reports absent peripheral with a row of red LEDs.
  • Enables CONFIG_BT_SMP_ALLOW_UNAUTH_OVERWRITE by default
  • nix build: exports generated kconfig and dts alongside build result

CONFIG_BT_CTLR_TX_PWR_PLUS_8=y

# Use non-legacy LLCP (required for compatibility with recent Linux kernel)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this will work anymore because of the following from app/Kconfig:

choice BT_LL_SW_LLCP_IMPL
    default BT_LL_SW_LLCP_LEGACY if !ZMK_BLE_EXPERIMENTAL_CONN

We need to use ZMK_BLE_EXPERIMENTAL_CONN rather than set all the flags individually so BT_LL_SW_LLCP_IMPL will remain the default (CONFIG_BT_LL_SW_LLCP).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Discord, my understanding of this was wrong. You can safely ignore this comment.

@chrisandreae chrisandreae merged commit 8883773 into main Jan 17, 2024
77 checks passed
@chrisandreae chrisandreae deleted the release-candidate branch June 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants