Skip to content

Commit

Permalink
Merge pull request #4117 from pleroy/17.11.5
Browse files Browse the repository at this point in the history
Support for VS 17.11.5
  • Loading branch information
pleroy authored Oct 16, 2024
2 parents 6afb36e + 92e387a commit ff268a0
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 9 deletions.
3 changes: 2 additions & 1 deletion base/not_null_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ TEST_F(NotNullTest, Move) {
_MSC_FULL_VER == 193'833'135 || \
_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120)
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123)
EXPECT_THAT(*(std::unique_ptr<int> const&)int_ptr1, Eq(3));
#endif
not_null<std::unique_ptr<int>> int_ptr2 = std::move(int_ptr1);
Expand Down
12 changes: 8 additions & 4 deletions geometry/hilbert.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ struct Hilbert<T1, T2> : not_constructible {
_MSC_FULL_VER == 193'833'135 || \
_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123
{ // NOLINT
return _grassmann::internal::InnerProduct(t1, t2);
}
Expand Down Expand Up @@ -100,7 +101,8 @@ struct Hilbert<T, T> : not_constructible {
_MSC_FULL_VER == 193'833'135 || \
_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123
{ // NOLINT
return _grassmann::internal::InnerProduct(t1, t2);
}
Expand All @@ -121,7 +123,8 @@ struct Hilbert<T, T> : not_constructible {
_MSC_FULL_VER == 193'833'135 || \
_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123
{ // NOLINT
return t.Norm²();
}
Expand All @@ -142,7 +145,8 @@ struct Hilbert<T, T> : not_constructible {
_MSC_FULL_VER == 193'833'135 || \
_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123
{ // NOLINT
return t.Norm();
}
Expand Down
3 changes: 2 additions & 1 deletion geometry/hilbert_body.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ auto Hilbert<T, T>::Norm(T const& t) -> NormType {
_MSC_FULL_VER == 193'833'135 || \
_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120)
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123)
template<typename T1, typename T2>
requires hilbert<T1, T2>
auto Hilbert<T1, T2>::InnerProduct(T1 const& t1, T2 const& t2)
Expand Down
3 changes: 2 additions & 1 deletion numerics/polynomial_in_чебышёв_basis_body.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ PolynomialInЧебышёвBasis<Value_, Argument_, std::nullopt>::ReadFromMessag
#if PRINCIPIA_COMPILER_MSVC && \
(_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120)
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123)
std::abort();
#endif
}
Expand Down
3 changes: 2 additions & 1 deletion physics/euler_solver_body.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,8 @@ EulerSolver<InertialFrame, PrincipalAxesFrame>::AttitudeAt(
#if PRINCIPIA_COMPILER_MSVC && \
(_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'120)
_MSC_FULL_VER == 194'134'120 || \
_MSC_FULL_VER == 194'134'123)
std::abort();
#endif
}
Expand Down
3 changes: 2 additions & 1 deletion tools/journal_proto_processor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,8 @@ std::string JournalProtoProcessor::MarshalAs(
LOG(FATAL) << "Bad marshaler for " << descriptor->name();
#if PRINCIPIA_COMPILER_MSVC && \
(_MSC_FULL_VER == 193'933'523 || \
_MSC_FULL_VER == 194'033'813)
_MSC_FULL_VER == 194'033'813 || \
_MSC_FULL_VER == 194'134'123)
std::abort();
#endif
}
Expand Down

0 comments on commit ff268a0

Please sign in to comment.